Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4206 Create New HtmlParser Factory Method #5277

Merged
merged 25 commits into from
Jan 22, 2024
Merged

Fix #4206 Create New HtmlParser Factory Method #5277

merged 25 commits into from
Jan 22, 2024

Conversation

XichengSpencer
Copy link
Collaborator

@XichengSpencer XichengSpencer commented Dec 19, 2023 •
edited
Loading

Explanation

Fix #4206 Create New HtmlParser Factory Method to only take customOppiaTagActionListener and displayLocale as parameter and replace factory method usage in MathExpressionParserViewModel with this new implementation

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
    Screenshot 2024-01-07 142738

Screenshot 2024-01-07 145604

XichengSpencer and others added 18 commits July 4, 2023 01:01
@XichengSpencer
Resolve the test build error
3936364
@XichengSpencer
Change 1 concatenate string to 3 seperate text view
ed714a6
@XichengSpencer
format code
f1c1bac
@XichengSpencer
Merge branch 'oppia:develop' into oppia#3843
31b6f53
@XichengSpencer
Change the corresponding test.
24050dc
@adhiamboperes
Merge branch 'develop' into oppia#3843
3406c78
@XichengSpencer
Merge remote-tracking branch 'origin/oppia#3843' into oppia#3843
b1bfe10
@XichengSpencer
Remove TODO
9c56e24
@XichengSpencer
Merge branch 'develop' into oppia#3843
8d9cf96
@XichengSpencer
remove testAddProfileActivity_inputPin_configChange_downloadAccessSwi…
6fe9746 
…tchIsOn() as discussed

, fix enable download access logic
,improve testAddProfileActivity_configChange_inputShortPin_create_pinLengthError() but still flaky
@XichengSpencer
Merge branch 'develop' of https://github.com/oppia/oppia-android into o…
1cbe96d 
…ppia#3843
@adhiamboperes
Merge branch 'develop' into oppia#3843
582f69d
@XichengSpencer
Add comment to explain the negating logic
40c44df
@XichengSpencer
Merge remote-tracking branch 'origin/oppia#3843' into oppia#3843
6824346
@adhiamboperes
Merge branch 'develop' into oppia#3843
ebe5a28
@XichengSpencer
Add new HtmlParser create method that use less variables
b4b5f10
@XichengSpencer
Merge branch 'develop' of https://github.com/oppia/oppia-android into o…
4802202 
…ppia#3843
@XichengSpencer
Merge remote-tracking branch 'origin/oppia#3843' into oppia#3843
e40a900
@XichengSpencer XichengSpencer requested a review from a team as a code owner December 19, 2023 17:20
@adhiamboperes adhiamboperes self-assigned this Dec 20, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 27, 2023

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 27, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jan 2, 2024
adhiamboperes
adhiamboperes requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XichengSpencer!

Do you need to update the MathExpressionParser tests as well to use this new method?

utility/src/main/java/org/oppia/android/util/parser/html/HtmlParser.kt Show resolved Hide resolved
adhiamboperes
adhiamboperes requested changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XichengSpencer!

Left a couple of minor comments.

utility/src/main/java/org/oppia/android/util/parser/html/HtmlParser.kt Outdated Show resolved Hide resolved
.../java/org/oppia/android/app/devoptions/mathexpressionparser/MathExpressionParserViewModel.kt Show resolved Hide resolved
adhiamboperes
adhiamboperes approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XichengSpencer! This LGTM!

@adhiamboperes adhiamboperes merged commit b173a2a into oppia:develop Jan 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@XichengSpencer XichengSpencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MathExpressionParserViewModel html parser usage with better factory function
2 participants
@XichengSpencer @adhiamboperes